add try/catch to calls to PerformanceObserver.prototype.observe and add tests#30554
Merged
jridgewell merged 6 commits intoampproject:masterfrom Oct 12, 2020
Merged
Conversation
66cf2ed to
566ba89
Compare
566ba89 to
6751698
Compare
jridgewell
requested changes
Oct 8, 2020
|
|
eadfcfa to
e8d9c98
Compare
samouri
approved these changes
Oct 12, 2020
jridgewell
reviewed
Oct 12, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…dd tests (ampproject#30554) * add test for performance observer throws * apply prettier * consolidate observe calls into method * Fix lints * remove TAG reference * Fix dev call Co-authored-by: Justin Ridgewell <jridgewell@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the performance tracking instance is initialized very early in the amp initialization lifecycle. A throw to a call to
observecan occur and break the initialization of the whole runtime. Make it more resilient to this case by wrapping all calls to observe in a try catch block