--files flag windows support#30222
Merged
samouri merged 3 commits intoampproject:masterfrom Sep 14, 2020
Merged
Conversation
rsimha
approved these changes
Sep 14, 2020
Contributor
rsimha
left a comment
There was a problem hiding this comment.
Agree with both the fix and the TODO.
Member
Author
|
Such a speedy review! Thanks @rsimha |
jridgewell
approved these changes
Sep 14, 2020
Comment on lines
+100
to
+103
| argv.files | ||
| .split(',') | ||
| .map((s) => s.trim()) | ||
| .map(toPosix) |
Contributor
There was a problem hiding this comment.
Nit: We can run this once instead of n:
Suggested change
| argv.files | |
| .split(',') | |
| .map((s) => s.trim()) | |
| .map(toPosix) | |
| toPosix(argv.files) | |
| .split(/\s*,\s*/) |
Member
Author
There was a problem hiding this comment.
I'm mildly ashamed to admit I don't know how this works 😬
Member
Author
There was a problem hiding this comment.
Oh wait, I get it. Thats super clever. I didn't know .split accepted regexes. Not going to switch from a readability standpoint...using my own confusion as a litmus test :)
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* --files flag windows support * Update utils.js * lint-rollin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Globby does not support windows paths.
This fix worked for
--flags, but we may want to look into switching to a lib that explicitly cares about Windows support.