🐛 jss transform: support watch mode by allowing dupes if same file#30115
Merged
samouri merged 4 commits intoampproject:masterfrom Sep 9, 2020
Merged
🐛 jss transform: support watch mode by allowing dupes if same file#30115samouri merged 4 commits intoampproject:masterfrom
samouri merged 4 commits intoampproject:masterfrom
Conversation
|
Hey @erwinmombay, @jridgewell! These files were changed: |
jridgewell
approved these changes
Sep 8, 2020
Contributor
|
thanks! |
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…mpproject#30115) * jss transform: support watch mode by allowing dupes if same file * unit test * fix tests * remove describes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
The recently introduced jss transform bans duplicate classnames from appearing.
As written, it breaks
watchmode since when the same file is compiled twice it of course generates the same classnames.This PR fixes it by allowing for dupes within the same file.