amp-list: support amp-state and amp-script for load-more#30101
Merged
samouri merged 6 commits intoampproject:masterfrom Sep 9, 2020
Merged
amp-list: support amp-state and amp-script for load-more#30101samouri merged 6 commits intoampproject:masterfrom
samouri merged 6 commits intoampproject:masterfrom
Conversation
jridgewell
approved these changes
Sep 8, 2020
caroqliu
approved these changes
Sep 9, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…30101) * amp-list: support amp-state and amp-script for loadMore * clean up separation between append/reg fetchlist * undo vscode setting * new fixture for e2e testing protocol adapters and loadmore * lint and add todo and fix tests * Update test-function-src.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Fixes #30095
The load-more option was broken when attempting to use it with
amp-scriptas a data source. This is because it has a separate fetch flow that didn't consideramp-script:oramp-state:URIs.This PR combines the two fetch flows, as well as adds a new e2e test for this interaction. In a future PR we should add documentation for how these two features interact.