Skip to content

jss: make classname deterministic#30065

Merged
samouri merged 9 commits intoampproject:masterfrom
samouri:jss-cx
Sep 2, 2020
Merged

jss: make classname deterministic#30065
samouri merged 9 commits intoampproject:masterfrom
samouri:jss-cx

Conversation

@samouri
Copy link
Copy Markdown
Member

@samouri samouri commented Aug 31, 2020 •
edited
Loading

summary

  • Introduces a new key for classname output: key-filehash. This means you'll get a stable key independent of order in which files are transformed, but there is a very small possibility of collisions.
  • Introduces a check to fail-fast in case there is a classname collision between files.

@google-cla google-cla bot added the cla: yes label Aug 31, 2020
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Aug 31, 2020 •
edited
Loading

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/babel-plugins/babel-plugin-transform-jss/index.js
build-system/babel-plugins/babel-plugin-transform-jss/test/fixtures/transform-assertions/should-transform-jss-var/output.mjs
build-system/babel-plugins/babel-plugin-transform-jss/test/fixtures/transform-assertions/should-transform-literal/input.js
build-system/babel-plugins/babel-plugin-transform-jss/test/fixtures/transform-assertions/should-transform-literal/output.mjs
build-system/babel-plugins/babel-plugin-transform-jss/test/index.js

@samouri samouri changed the title 🐛 jss: make classname deterministic jss: make classname deterministic Aug 31, 2020
@samouri samouri requested a review from dvoytenko August 31, 2020 21:16
@samouri samouri self-assigned this Aug 31, 2020
@samouri samouri requested a review from jridgewell August 31, 2020 21:19
jridgewell
jridgewell reviewed Aug 31, 2020
View reviewed changes
dvoytenko
dvoytenko suggested changes Sep 1, 2020
View reviewed changes
dvoytenko
dvoytenko suggested changes Sep 1, 2020
View reviewed changes
@samouri samouri requested a review from dvoytenko September 2, 2020 16:43
@samouri samouri merged commit 6469a3c into ampproject:master Sep 2, 2020
@samouri samouri deleted the jss-cx branch September 2, 2020 18:54
@samouri samouri mentioned this pull request Sep 14, 2020
Closed
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@samouri @ed-bird
jss: make classname deterministic (ampproject#30065)
f8bdd72 
* jss: make classname deterministic

* filehash

* typo

* test should work on windows

* Use sha256

* lint

* relativize filepath to project so hashes are independent of machine

* review fixes

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jridgewell jridgewell jridgewell approved these changes

+1 more reviewer

@dvoytenko dvoytenko dvoytenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samouri samouri

Labels

cla: yes PR use: In Beta / Experimental

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samouri @jridgewell @dvoytenko @ampprojectbot