New icons and new data-ampdevmode for Validator extension#30011
Merged
honeybadgerdontcare merged 7 commits intoampproject:masterfrom Aug 28, 2020
Merged
New icons and new data-ampdevmode for Validator extension#30011honeybadgerdontcare merged 7 commits intoampproject:masterfrom
honeybadgerdontcare merged 7 commits intoampproject:masterfrom
Conversation
|
Hey @ampproject/wg-caching! These files were changed: |
Gregable
requested changes
Aug 27, 2020
westonruter
reviewed
Aug 28, 2020
Member
westonruter
left a comment
There was a problem hiding this comment.
The updated logic works as expected!
However, I have some feedback about the icon changes. I had a difficult time seeing the icon badge associated with the AMP icon for everything other than the error state. I had to squint to see the 🔗 ,
As such, I think they need improvement for accessibility.
| State | Icon |
|---|---|
| Error |  |
| Dev Mode |  |
| Pass |  |
| Available |  |
Contributor
Author
|
@Gregable please re-review, requested changes made |
westonruter
approved these changes
Aug 28, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…#30011) * new chrome extension icons * add dev mode setting * minor fixes, update version * remove anti-pattern * Elaborate isInDevMode condition in comment. * remove badgetitle from handleamppass * s/isInDevMode/onlyErrorIsDevMode/g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #24176
updates look of existing icons
introduces new dev mode icon when data-ampdevmode is on html tag
removes number of warnings from icon when page is passing validation (e.g. warnings only)
updates background color for failing validation