📖 Docs for AMP version of the amp-story-player#29922
📖 Docs for AMP version of the amp-story-player#29922Enriqe merged 3 commits intoampproject:masterfrom
Conversation
|
Hey @gmajoulet, @newmuis, @alanorozco, @wassgha! These files were changed: |
|
PTAL |
gmajoulet
left a comment
There was a problem hiding this comment.
LGTM as long as it LGTCrystal :))
CrystalOnScript
left a comment
There was a problem hiding this comment.
Awesome that this is launching! Very exciting - I have a format nit. Also, I feel this is a component devs would be very interested in styling, do we have any advice or gotchas? The gif we have embedded is a mobile phone that shows the tap motion - when a story is embedded will it look the same or does it come with additional UI elements?
27bc347 to
dbadf6e
Compare
Enriqe
left a comment
There was a problem hiding this comment.
when a story is embedded will it look the same or does it come with additional UI elements?
It would look the same, we have some primitive UI options but those are not available in the AMP version yet.
CrystalOnScript
left a comment
There was a problem hiding this comment.
Just the table nit - otherwise LGTM
* docs * adress comments * remove table
Closes #29312
Pretty much what is already said in https://github.com/ampproject/amphtml/blob/master/spec/amp-story-player.md , but cutting off any unsupported/unreleased features for the AMP version