Skip to content

amp-script: dont assign onerror if failed to init#29875

Merged
samouri merged 1 commit intoampproject:masterfrom
samouri:fix-null-script
Aug 18, 2020
Merged

amp-script: dont assign onerror if failed to init#29875
samouri merged 1 commit intoampproject:masterfrom
samouri:fix-null-script

Conversation

@samouri
Copy link
Copy Markdown
Member

@samouri samouri commented Aug 18, 2020

Fixes #29860

@google-cla google-cla bot added the cla: yes label Aug 18, 2020
@samouri samouri requested review from jridgewell and morsssss August 18, 2020 15:32
@morsssss
Copy link
Copy Markdown
Contributor

woo, thanks!

@samouri samouri merged commit 6ba82eb into ampproject:master Aug 18, 2020
@samouri samouri deleted the fix-null-script branch August 18, 2020 17:03
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

amp-script: error thrown if remote script is too large

4 participants