Fix AMP.navigateTo with relative URLs on cache#29842
Merged
dreamofabear merged 3 commits intoampproject:masterfrom Aug 18, 2020
Merged
Fix AMP.navigateTo with relative URLs on cache#29842dreamofabear merged 3 commits intoampproject:masterfrom
dreamofabear merged 3 commits intoampproject:masterfrom
Conversation
jridgewell
approved these changes
Aug 17, 2020
Author
|
@ampproject/wg-ads-reviewers Can I get a bundle size approval please? |
powerivq
approved these changes
Aug 18, 2020
Member
|
Gool |
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Fix AMP.navigateTo with relative URLs on cache. * Add resolveRelativeUrl to URL service. * Remove import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26248 and patches #22376.
getSourceUrl('/path/to/page.html')causes a userAssert on cache since*.cdn.ampproject.org/path/is not a valid CDN prefix