Skip to content

⏪ Temporarily revert lazy polyfill web animations#29772

Merged
kristoferbaxter merged 2 commits intoampproject:masterfrom
kristoferbaxter:revert-polyfill-animations
Aug 10, 2020
Merged

⏪ Temporarily revert lazy polyfill web animations#29772
kristoferbaxter merged 2 commits intoampproject:masterfrom
kristoferbaxter:revert-polyfill-animations

Conversation

@kristoferbaxter
Copy link
Copy Markdown
Contributor

It's not currently possible to preloadExtension within a child iframe. This PR was always installing on the parent frame.

@kristoferbaxter kristoferbaxter merged commit 933c001 into ampproject:master Aug 10, 2020
@kristoferbaxter kristoferbaxter deleted the revert-polyfill-animations branch August 10, 2020 23:28
kristoferbaxter added a commit that referenced this pull request Aug 10, 2020
calebcordry pushed a commit that referenced this pull request Aug 11, 2020
* Revert polyfill web animations lazily due to issue with FIE
* Type was wrong

(cherry picked from commit 933c001)
kristoferbaxter added a commit that referenced this pull request Aug 11, 2020
* Revert "⏪ Temporarily revert lazy polyfill web animations (#29772)"

This reverts commit 933c001.

* Install polyfill into child window

* Update install-polyfill.js

Cleanup

Co-authored-by: Justin Ridgewell <jridgewell@google.com>
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
* Revert polyfill web animations lazily due to issue with FIE
* Type was wrong
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
…t#29775)

* Revert "⏪ Temporarily revert lazy polyfill web animations (ampproject#29772)"

This reverts commit 933c001.

* Install polyfill into child window

* Update install-polyfill.js

Cleanup

Co-authored-by: Justin Ridgewell <jridgewell@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants