🐛 Clone IntersectionObserverEntry for cross-origin postMessages#29771
Merged
jridgewell merged 1 commit intoampproject:masterfrom Aug 10, 2020
Merged
🐛 Clone IntersectionObserverEntry for cross-origin postMessages#29771jridgewell merged 1 commit intoampproject:masterfrom
jridgewell merged 1 commit intoampproject:masterfrom
Conversation
Contributor
Author
|
/to @calebcordry |
The `target` property points to a DOM element, which is not structured clonable (a requirement for `postMessage`). We used to `delete entry.target`, to get around this. But when using native `IntersectionObserver`, the `IntersectionObserverEntry`s has no own properties. Instead, the properties are getters that exist on the prototype. `delete` doesn't work for prototype-inherited properties, so this workaround stopped working. Now, we'll just create a new object with the properties we care about, which is honestly cleaner (you shouldn't mutate objects you don't own). Fixes ampproject#29747
813c078 to
b4b7a60
Compare
kristoferbaxter
approved these changes
Aug 10, 2020
calebcordry
approved these changes
Aug 10, 2020
calebcordry
pushed a commit
that referenced
this pull request
Aug 11, 2020
The `target` property points to a DOM element, which is not structured clonable (a requirement for `postMessage`). We used to `delete entry.target`, to get around this. But when using native `IntersectionObserver`, the `IntersectionObserverEntry`s has no own properties. Instead, the properties are getters that exist on the prototype. `delete` doesn't work for prototype-inherited properties, so this workaround stopped working. Now, we'll just create a new object with the properties we care about, which is honestly cleaner (you shouldn't mutate objects you don't own). Fixes #29747 (cherry picked from commit 85440b5)
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
…ject#29771) The `target` property points to a DOM element, which is not structured clonable (a requirement for `postMessage`). We used to `delete entry.target`, to get around this. But when using native `IntersectionObserver`, the `IntersectionObserverEntry`s has no own properties. Instead, the properties are getters that exist on the prototype. `delete` doesn't work for prototype-inherited properties, so this workaround stopped working. Now, we'll just create a new object with the properties we care about, which is honestly cleaner (you shouldn't mutate objects you don't own). Fixes ampproject#29747
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
targetproperty points to a DOM element, which is not structured clonable (a requirement forpostMessage). We used todelete entry.target, to get around this.But when using native
IntersectionObserver, theIntersectionObserverEntrys has no own properties. Instead, the properties are getters that exist on the prototype.deletedoesn't work for prototype-inherited properties, so this workaround stopped working. Now, we'll just create a new object with the properties we care about, which is honestly cleaner (you shouldn't mutate objects you don't own).Fixes #29747