new lint rule: no static this#29692
Merged
samouri merged 2 commits intoampproject:masterfrom Aug 7, 2020
Merged
Conversation
jridgewell
approved these changes
Aug 5, 2020
|
Hey @erwinmombay, @jridgewell! These files were changed: |
kristoferbaxter
approved these changes
Aug 5, 2020
Contributor
kristoferbaxter
left a comment
There was a problem hiding this comment.
Nice work @samouri and @jridgewell!
Contributor
|
The remaining condition flagged was addressed in master, should be able to merge it in and then we can commit this ESLint rule. |
jridgewell
approved these changes
Aug 7, 2020
Member
Author
|
Note: this completes the AIs from #29499 |
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* new lint rule: no static this * remove a harmless instance of static this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closure Compiler doesn't support static this. It doesn't explode either, it just behaves strangely at runtime.
This lint rule should help up catch it early.
Most of the credit goes to Justin for writing the meat of the rule.
cc @kristoferbaxter
Blocked by #29695