🐛 inputmask: remove static from fn using this#29646
Merged
samouri merged 2 commits intoampproject:masterfrom Aug 4, 2020
Merged
🐛 inputmask: remove static from fn using this#29646samouri merged 2 commits intoampproject:masterfrom
this#29646samouri merged 2 commits intoampproject:masterfrom
Conversation
|
Gool |
dreamofabear
approved these changes
Aug 4, 2020
jridgewell
requested changes
Aug 4, 2020
Contributor
jridgewell
left a comment
There was a problem hiding this comment.
I think the intention was for this to initialize the Inputmask only once, and this will create one for each element. Mind correcting this?
Member
Author
|
@jridgewell: I don't see how initializing only once could be correct given that In practice, the cache is never used in sloppy mode. The cache lookup is done against |
jridgewell
approved these changes
Aug 4, 2020
caroqliu
approved these changes
Aug 4, 2020
calebcordry
pushed a commit
that referenced
this pull request
Aug 11, 2020
calebcordry
pushed a commit
that referenced
this pull request
Aug 11, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* inputmask: remove static from fn using `this` * fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29499
Causes a bug due to: google/closure-compiler#2397