Fix userAssert's type annotation#28191
Merged
jridgewell merged 4 commits intoampproject:masterfrom May 5, 2020
Merged
Conversation
Matches `devAssert`'s change in ampproject#24047.
samouri
reviewed
May 5, 2020
| * @return {T} The value of shouldBeTrueish. | ||
| * @throws {!Error} When `shouldBeTrueish` is falsey. | ||
| * @template T | ||
| * @template R := |
rsimha
approved these changes
May 5, 2020
| * @return {T} The value of shouldBeTrueish. | ||
| * @throws {!Error} When `shouldBeTrueish` is falsey. | ||
| * @template T | ||
| * @template R := |
erwinmombay
approved these changes
May 5, 2020
Closure is narrowing the type to `Object` due to the `typeof x === 'object'` check. Seems like a bug.
jridgewell
commented
May 5, 2020
| // See https://github.com/google/closure-compiler/wiki/Warnings#warnings-categories | ||
| // for a full list of closure's default error / warning levels. | ||
| if (options.typeCheckOnly) { | ||
| compilerOptions.checks_only = true; |
Contributor
Author
There was a problem hiding this comment.
Save 30s with with this one weird trick.
ldoroshe
pushed a commit
to ldoroshe/amphtml
that referenced
this pull request
May 8, 2020
* Fix userAssert's type annotation Matches `devAssert`'s change in ampproject#24047. * Remove old notes * Add single cast Closure is narrowing the type to `Object` due to the `typeof x === 'object'` check. Seems like a bug. * Speed up check-types by 30s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches
devAssert's change in #24047.