Skip to content

Add preset-us-ca set to amp-geo#27571

Merged
zhouyx merged 1 commit intoampproject:masterfrom
zhouyx:amp-geo-us-ca
Apr 8, 2020
Merged

Add preset-us-ca set to amp-geo#27571
zhouyx merged 1 commit intoampproject:masterfrom
zhouyx:amp-geo-us-ca

Conversation

@zhouyx
Copy link
Copy Markdown
Contributor

@zhouyx zhouyx commented Apr 4, 2020

Closes #26637

Add preset-us-ca set before we have generic ISO subdivision support.

The new {{AMP_ISO_COUNTRY_HOTPATCH}} replaced format will be
"us " or "us us-ca " (string length stays the same)

@amp-owners-bot amp-owners-bot bot requested a review from jpettitt April 4, 2020 01:55
@zhouyx zhouyx requested a review from micajuine-ho April 4, 2020 01:55
Copy link
Copy Markdown
Contributor

@micajuine-ho micajuine-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohooo!

@zhouyx zhouyx merged commit ad63bc4 into ampproject:master Apr 8, 2020
@zhouyx zhouyx deleted the amp-geo-us-ca branch April 8, 2020 22:24
zhouyx added a commit to zhouyx/amphtml that referenced this pull request Apr 9, 2020
@mdmower
Copy link
Copy Markdown
Contributor

mdmower commented Apr 15, 2020

Hi @zhouyx - Could you ping me when string replacements for {{AMP_ISO_COUNTRY_HOTPATCH}} are updated? I aim to keep the hosting guide, @amp-toolbox/runtime-fetch, and the amp-geo fallback API up-to-date.

Also, someone may want to update the AMP cache guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I2I: amp-geo to add preset-us-ca

6 participants