✨ amp-bind: allow facetime protocol for links#27134
Merged
samouri merged 4 commits intoampproject:masterfrom Mar 10, 2020
Merged
✨ amp-bind: allow facetime protocol for links#27134samouri merged 4 commits intoampproject:masterfrom
samouri merged 4 commits intoampproject:masterfrom
Conversation
kristoferbaxter
approved these changes
Mar 6, 2020
dreamofabear
reviewed
Mar 6, 2020
dreamofabear
left a comment
There was a problem hiding this comment.
bind-validator.js is meant to mirror the AMP validator, so we should probably enable this in validator-main.protoascii as well.
Contributor
|
There are a lot of permitted anchor tag protocols that aren't reflected in the bind-validator file. See https://github.com/ampproject/amphtml/blob/master/validator/validator-main.protoascii#L1879. Should we file an issue to include those in bind or is it intentional it's only a subset in bind? |
|
Good point, we should add those. |
|
Hey @ampproject/wg-caching, these files were changed: |
dreamofabear
approved these changes
Mar 10, 2020
honeybadgerdontcare
approved these changes
Mar 10, 2020
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Mar 12, 2020
Merged
twifkak
added a commit
that referenced
this pull request
Mar 12, 2020
* cl/299411284 Allow links with `tel` scheme in email spec * cl/300054759 github commit msg missing or malformed * cl/300575599 Revision bump for #27098 * cl/300578001 Revision bump for #27132 * cl/300590811 Revision bump for #27027 * cl/300593269 Revision bump for #27170 * cl/300596115 Revision bump for #27134 * cl/300598356 Revision bump for #27076 * cl/300599497 Revision bump for #26912 Co-authored-by: honeybadgerdontcare <sedano@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #26098