Improve visibility event tests#26847
Merged
micajuine-ho merged 2 commits intoampproject:masterfrom Feb 28, 2020
Merged
Conversation
zhouyx
suggested changes
Feb 27, 2020
| expect(event.type).to.equal('visible'); | ||
| expect(event.vars.totalVisibleTime).to.equal(10); | ||
| expect(unlisten).to.be.not.called; | ||
| await res(); |
Contributor
There was a problem hiding this comment.
The test checks if the unlistener from tracker.add() is called afterward but invoking res() calls the unlistener manually. Please fix
Contributor
Author
There was a problem hiding this comment.
As discussed offline, we will remove the check for unlisten (because it doesn't have too much value)
zhouyx
reviewed
Feb 28, 2020
| config, | ||
| eventResolver | ||
| ); | ||
| expect(res).to.be.a('function'); |
Contributor
There was a problem hiding this comment.
I'll say checking the return value of add is a function is still valuable because it prevent cases where one fail to return an unlistener.
zhouyx
approved these changes
Feb 28, 2020
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Mar 2, 2020
* master: Launch `amp-next-page` v2 & clean up experiment (ampproject#27035) ✨Implement Display Locking on amp-accordion (ampproject#25867) 📖<amp-next-page> documentation and validation (ampproject#26841) Improve visibility event tests (ampproject#26847) amp-geo: Fall back to API for country (ampproject#26407) ✨ Add customization options to <amp-story-quiz> (ampproject#26714) navigation: Minor test improvements (ampproject#26926) ♻️ Alias video.fullscreen action for symmetry with interface names (ampproject#27017) ✨ Implements `amp-analytics` support for `amp-next-page` (ampproject#26451) ✨ amp-video-iframe integration: global jwplayer() singleton by default (ampproject#26969) Fix unit tests broken by ampproject#26687 (ampproject#27000) Filter redirect info from emails (ampproject#27012) 📖 Make amp-bind doc valid, fix amp-form stories filter (ampproject#27003) url-replacements: Minor test improvement (ampproject#26930) viewport: Minor test improvement (ampproject#26931) amp-consent fullscreen warning (ampproject#26467) dep-check: USE CAPS FOR IMPORTANCE (ampproject#26993) fix img url (ampproject#26987) # Conflicts: # extensions/amp-next-page/amp-next-page.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing
function*toasyncand removing unlisten