a4a: RefreshManager: Support amp-ad-enable-refresh lookup in AmpDocShadow#26840
Merged
mdmower merged 1 commit intoampproject:masterfrom Mar 21, 2020
Merged
a4a: RefreshManager: Support amp-ad-enable-refresh lookup in AmpDocShadow#26840mdmower merged 1 commit intoampproject:masterfrom
mdmower merged 1 commit intoampproject:masterfrom
Conversation
…adow Read meta[name="amp-ad-enable-refresh"] using method supported by AmpDocShadow as well as other AmpDoc subtypes.
33 tasks
Member
|
Sorry for the delay, I like this API much better :) |
calebcordry
approved these changes
Mar 14, 2020
twintwox
pushed a commit
to twintwox/amphtml
that referenced
this pull request
Mar 24, 2020
…adow (ampproject#26840) Read meta[name="amp-ad-enable-refresh"] using method supported by AmpDocShadow as well as other AmpDoc subtypes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read
meta[name="amp-ad-enable-refresh"]using method supported byAmpDocShadowas well as otherAmpDocsubtypes.