Skip to content

✨amp-inline-gallery docs and validation rules#26708

Merged
alanorozco merged 2 commits intoampproject:masterfrom
alanorozco:aig
Feb 10, 2020
Merged

✨amp-inline-gallery docs and validation rules#26708
alanorozco merged 2 commits intoampproject:masterfrom
alanorozco:aig

Conversation

@alanorozco
Copy link
Copy Markdown
Member

@alanorozco alanorozco commented Feb 10, 2020

Unchanged clone of #26109, which had to be closed due to Github user email change/CLA issues.

  • Add docs for amp-inline-gallery elements and linking to amp-base-carousel for its usage.
  • Add validation rules for amp-inline-gallery elements.
  • Fix selector for finding the amp-base-carousel, when it is a direct child of the amp-inline-gallery.

@amp-owners-bot
Copy link
Copy Markdown

Hey @ampproject/wg-caching, these files were changed:

  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-pagination.html
  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-pagination.out
  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-thumbnails.html
  • extensions/amp-inline-gallery/0.1/test/validator-amp-inline-gallery-thumbnails.out
  • extensions/amp-inline-gallery/validator-amp-inline-gallery.protoascii

@alanorozco alanorozco merged commit e3be1b2 into ampproject:master Feb 10, 2020
@alanorozco alanorozco deleted the aig branch February 10, 2020 23:12
honeybadgerdontcare added a commit that referenced this pull request Feb 12, 2020
* cl/294457507 Revision bump for #26475

* cl/294516530 Revision bump for #26708

* cl/294516739 Update node.js version numbers

* cl/294681603 Revision bump for #26747

Co-authored-by: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
amaltas added a commit that referenced this pull request Feb 12, 2020
* cl/294457507 Revision bump for #26475

* cl/294516530 Revision bump for #26708

* cl/294516739 Update node.js version numbers

* cl/294681603 Revision bump for #26747

* Update package versions and README for nodejs and gulpjs. (Packages are
pushed  to npm repository)

Co-authored-by: honeybadgerdontcare <honeybadgerdontcare@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants