amp-ad: Support amp-3p-iframe-src lookup in AmpDocShadow#26682
Merged
mdmower merged 3 commits intoampproject:masterfrom Mar 21, 2020
Merged
amp-ad: Support amp-3p-iframe-src lookup in AmpDocShadow#26682mdmower merged 3 commits intoampproject:masterfrom
mdmower merged 3 commits intoampproject:masterfrom
Conversation
This was referenced Feb 9, 2020
Query meta[name="amp-3p-iframe-src"] using method supported by AmpDocShadow as well as other AmpDoc subtypes.
Contributor
Author
|
Unit test is failing. Requires #26855 |
samouri
reviewed
Feb 21, 2020
samouri
approved these changes
Feb 21, 2020
lannka
approved these changes
Mar 13, 2020
Contributor
Author
|
Re-ran Travis CI as a precaution since it's been quite a while since this was posted. Looks like there are new test failures. Will revise. |
- Simplify div.getAmpDoc to return an actual ampdoc - Clear cached meta after each test
twintwox
pushed a commit
to twintwox/amphtml
that referenced
this pull request
Mar 24, 2020
…26682) * amp-ad: Support amp-3p-iframe-src lookup in ShadowRoot Query meta[name="amp-3p-iframe-src"] using method supported by AmpDocShadow as well as other AmpDoc subtypes. * Handle cached meta in 3p-frame test - Simplify div.getAmpDoc to return an actual ampdoc - Clear cached meta after each test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Query
meta[name="amp-3p-iframe-src"]using method supported byAmpDocShadowas well as otherAmpDocsubtypes.