Fix shadow test state pollution#26607
Merged
calebcordry merged 1 commit intoampproject:masterfrom Feb 5, 2020
calebcordry:runtime-debug
Merged
Fix shadow test state pollution#26607calebcordry merged 1 commit intoampproject:masterfrom calebcordry:runtime-debug
calebcordry merged 1 commit intoampproject:masterfrom
calebcordry:runtime-debug
Conversation
powerivq
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was debugging test failures in #26447 and found that if I ran
test-runtime.jsdirectly it would work, but if I rantest-shadow-embed.jswith it, it would always fail :(Turns out in some of our tests, we manually set the streaming supported flag through
setShadowDomStreamingSupportedForTesting. This value gets cached hereamphtml/src/shadow-embed.js
Lines 328 to 331 in eccff2d
These tests would reset this flag in a beforeEach block, but this would not clean up this state for the last test in the section, causing hard to track test failures.
Moves the resetting of this state to an afterEach block instead, which seems to solve the problem.