♻️Rename ShadowDomWriter* => DomWriter*#26447
Merged
calebcordry merged 6 commits intoampproject:masterfrom Feb 7, 2020
calebcordry:rename-shadow-writer
Merged
♻️Rename ShadowDomWriter* => DomWriter*#26447calebcordry merged 6 commits intoampproject:masterfrom calebcordry:rename-shadow-writer
calebcordry merged 6 commits intoampproject:masterfrom
calebcordry:rename-shadow-writer
Conversation
lannka
approved these changes
Jan 22, 2020
dvoytenko
reviewed
Jan 24, 2020
| @@ -0,0 +1,349 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
Should we move this to utils/?
Member
Author
|
Looking into test failures, I can repro on clean master so I think something strange is going on. |
Member
Author
|
Test failures should be fixed by #26607 when merged 🤞 |
dvoytenko
approved these changes
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename classes and move to their own file in preparation for ads use-case. After reviewing again, I don't think we will need to change the impl (not really anything shadow specific) but if necessary will do in a follow up PR.