Position n+1 story desktop page before positioning attributes are set.#26488
Merged
gmajoulet merged 1 commit intoampproject:masterfrom Jan 27, 2020
Merged
Conversation
Enriqe
approved these changes
Jan 24, 2020
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Jan 28, 2020
…frame-pymjs-support * 'master' of github.com:ampproject/amphtml: (436 commits) 🐛Add computed styles to fake win (ampproject#26514) 📦 Update dependency eslint-config-prettier to v6.10.0 (ampproject#26518) 🐛 Rewrite relative urls in the bookend (ampproject#26490) ✨ [amp-list] Introduce "amp-state:" as a usable protocol for the src attribute. (ampproject#26284) Add terminal newline to files.txt (ampproject#26513) 📦 Update dependency chromedriver to v79.0.2 (ampproject#26515) ♻️ Change the opt-in cookie values to reflect upcoming CDN changes (ampproject#26489) ♻️<amp-next-page> v2 minor renaming and fixes (ampproject#26468) fix link (ampproject#26508) amp-list: fix broken test re. missing layout (ampproject#26509) performance: emit timeOrigin w/ polyfill (ampproject#26485) Position n+1 story desktop page before positioning attributes are set. (ampproject#26488) ✨amp-nested-menu: allow svg into (ampproject#26502) Log user warning when missing URL arg for shadow doc (ampproject#26290) 📦 Update dependency puppeteer to v2.1.0 (ampproject#26501) Ensure that fluid slots hidden by media queries do not issue ad requests. (ampproject#26352) 📦 Update dependency mocha to v7.0.1 (ampproject#26495) 📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491) Revert 'Move mutator implementations out to a standalone service' (ampproject#26479) Fix syntax error (ampproject#26481) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a desktop panels story, the n+1 page isn't positioned until pretty late in the code execution, when we set positioning attributes. That n+1 page flies in the viewport once the position is set.
This PR positions the n+1 page until the final position attributes are set.
Repro the animation issue