Skip to content

Revert "♻️ Lint: include externs"#26445

Merged
rsimha merged 8 commits intomasterfrom
revert-26228-prettify-externs
Jan 22, 2020
Merged

Revert "♻️ Lint: include externs"#26445
rsimha merged 8 commits intomasterfrom
revert-26228-prettify-externs

Conversation

@samouri
Copy link
Copy Markdown
Member

@samouri samouri commented Jan 22, 2020 •
edited
Loading

Reverts #26228

Revert reasons (#26228 (comment)):

  1. Initial merge was done via 8 commits instead of a squashed 1
  2. There have been changes to the externs files that make them out of sync with the introduced lint rules (making master red)

@samouri samouri requested a review from rsimha January 22, 2020 22:46
@amp-owners-bot amp-owners-bot bot requested a review from jeffkaufman January 22, 2020 22:46
@rsimha
Copy link
Copy Markdown
Contributor

rsimha commented Jan 22, 2020

Verified that this revert fixes broken master. Force merging to unblock development.

@rsimha rsimha merged commit 989eb0c into master Jan 22, 2020
samouri added a commit that referenced this pull request Jan 22, 2020
@samouri
Revert "Revert "♻️ Lint: include externs" (#26445)"
42c4c4d 
This reverts commit 989eb0c.
@samouri samouri mentioned this pull request Jan 22, 2020
Merged
samouri added a commit that referenced this pull request Jan 23, 2020
@samouri
♻️ Lint: include externs (round 2) (#26446)
9faa367 
* Revert "Revert "♻️ Lint: include externs" (#26445)"

This reverts commit 989eb0c.

* prettify preact extern
@rsimha rsimha deleted the revert-26228-prettify-externs branch February 13, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jridgewell jridgewell jridgewell approved these changes

@jeffkaufman jeffkaufman Awaiting requested review from jeffkaufman

+1 more reviewer

@rsimha rsimha rsimha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samouri @rsimha @jridgewell @googlebot