🏗 Remove the engines section from all package.json files in amphtml#26427
Merged
rsimha merged 1 commit intoampproject:masterfrom Jan 21, 2020
rsimha:2020-10-21-RemoveEngines
Merged
🏗 Remove the engines section from all package.json files in amphtml#26427rsimha merged 1 commit intoampproject:masterfrom rsimha:2020-10-21-RemoveEngines
engines section from all package.json files in amphtml#26427rsimha merged 1 commit intoampproject:masterfrom
rsimha:2020-10-21-RemoveEngines
Conversation
Contributor
Author
|
@estherkim for infra review. |
sebastianbenz
approved these changes
Jan 21, 2020
Gregable
approved these changes
Jan 21, 2020
Contributor
Author
|
I verbally ran this by @ampproject/wg-infra this afternoon. This PR is good to merge. @honeybadgerdontcare / @Gregable: I'll leave it to you folks to decide if it's necessary to push a new release for the validator packages |
Contributor
kristoferbaxter
left a comment
There was a problem hiding this comment.
Sounds prudent to me for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
enginessection ofpackage.jsonhas traditionally been used to enforce a known good range of versions ofnodefor local development. This has worked well so far for developers who work on theamphtmlrepo, where we require an active LTS version ofnode(and recommend the latest active LTS version ofnode).However, we've had multiple instances in the past of the
enginessection ofpackage.jsoncoming in the way of developer workflows for external contributors who use sub-packages published from within theamphtmlrepo. See earlier relevant discussions in #19050, #19218, #25161, #25189, #25209, and #26408.In addition, it has caused failures on Travis CI when
nodepushes out a new version, causing ourpackage.jsonfiles to be outdated until they are manually updated.When I spoke to @MylesBorins at Open JS last month, he mentioned to me that the
enginessection is likely to be deprecated soon, and that a better way of enforcingnodeversions in a repo is to have tests / CI return an error for incompatible versions. We already do this foramphtmlvia build-system/common/check-package-manager.js.This PR deletes the
enginessection from allpackage.jsonfiles inamphtml.Fixes #26408
Closes #25209
Related to #19050, #19218, #25161, #25189, #25209, and #26408.