ssr intrinsic layout: support svg using apostroph#26294
Merged
sebastianbenz merged 1 commit intoampproject:masterfrom Mar 2, 2020
Merged
ssr intrinsic layout: support svg using apostroph#26294sebastianbenz merged 1 commit intoampproject:masterfrom
sebastianbenz merged 1 commit intoampproject:masterfrom
Conversation
|
Hey @ampproject/wg-caching, these files were changed: |
Gregable
approved these changes
Jan 13, 2020
2bf79b8 to
8f5dd1f
Compare
Contributor
Author
|
If changed the implementation to support both, escaped quotes or single quotes (before only escaped quotes were valid). This means, these two SVG placeholders will be valid: Reason for this change: in the meantime intrinsic support has been added to AMP Optimizer which has been using escaped quotes. |
Contributor
Author
jridgewell
approved these changes
Feb 27, 2020
Contributor
Author
|
Is there a way to re-trigger the build? |
This change updates the validatation of the intrinsic SVG placeholder to support either escaped quotes or single quotes (before only escaped quotes were valid). This means, these two SVG placeholders will be valid: ``` data:image/svg+xml;charset=utf-8,<svg height="100" width="300" xmlns="http://www.w3.org/2000/svg" version="1.1"/> data:image/svg+xml;charset=utf-8,<svg height='100' width='300' xmlns='http://www.w3.org/2000/svg' version='1.1'/> ```
8f5dd1f to
b1fd82e
Compare
Contributor
Author
|
Re-based against master to re-trigger the build. |
9 tasks
robinvanopstal
added a commit
to jungvonmatt/amphtml
that referenced
this pull request
Mar 2, 2020
* master: ssr intrinsic layout: support svg using apostroph (ampproject#26294)
Gregable
pushed a commit
that referenced
this pull request
Mar 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intrinsic layout validation originally required inline SVG attribute quotes to be escaped via
". To reduce char count, this PR changes the behavior to expect single quotes instead.This is a breaking change, however, I don't think that this will be an issue as intrinsic layout SSR hasn't been implemented anywhere. If this is a concern, we could change the implementation to support both.
//cc @jridgewell