Merged
Conversation
Contributor
banaag
commented
Nov 12, 2019
- cl/279442666 Revision bump for Add validation and documentation for <amp-nested-menu> #25339
- cl/279442666 Revision bump for Add validation and documentation for <amp-nested-menu> #25339
- cl/279189628 When heights or sizes is empty, the layout should be fixed
|
Hey @ampproject/wg-caching, these files were changed:
|
honeybadgerdontcare
approved these changes
Nov 12, 2019
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
please revert the two .out files that duplicate content, otherwise lgtm
Contributor
Author
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/279189628 When heights or sizes is empty, the layout should be fixed * cl/279442666 Revision bump for ampproject#25339 * Removed unwanted files from pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.