Add amp-form test for pre-existing redirection behavior#25515
Merged
caroqliu merged 3 commits intoampproject:masterfrom Nov 11, 2019
Merged
Add amp-form test for pre-existing redirection behavior#25515caroqliu merged 3 commits intoampproject:masterfrom
caroqliu merged 3 commits intoampproject:masterfrom
Conversation
…ubmit-error` events. (ampproject#25242)" This reverts commit 48d5ffd.
wassgha
approved these changes
Nov 8, 2019
Comment on lines
+2430
to
+2431
| sandbox.stub(ampForm.xhr_, 'fetch').returns( | ||
| Promise.resolve({ |
Contributor
Author
There was a problem hiding this comment.
Would prefer to keep as is since that is more self-consistent with other stubs in this file. WDYT?
Contributor
There was a problem hiding this comment.
👍 we can switch them on a different PR since this is a large file
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…5515) * Revert "🐛Expose amp-form response from SSR in `submit-success` and `submit-error` events. (ampproject#25242)" This reverts commit 48d5ffd. * Add test case for bad json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #25473 to prevent future breakage