Narrow down script matching to avoid incorrect prefix matches#25441
Merged
dvoytenko merged 4 commits intoampproject:masterfrom Nov 5, 2019
Merged
Narrow down script matching to avoid incorrect prefix matches#25441dvoytenko merged 4 commits intoampproject:masterfrom
dvoytenko merged 4 commits intoampproject:masterfrom
Conversation
jridgewell
approved these changes
Nov 5, 2019
dreamofabear
approved these changes
Nov 5, 2019
jridgewell
requested changes
Nov 5, 2019
jridgewell
approved these changes
Nov 5, 2019
erwinmombay
pushed a commit
that referenced
this pull request
Nov 5, 2019
* Narrow down script matching to avoid incorrect preffix matches * minor * Fix race condition on wait->reload * update script existence
11 tasks
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…ject#25441) * Narrow down script matching to avoid incorrect preffix matches * minor * Fix race condition on wait->reload * update script existence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25436.
Additionally fixes a race condition on the wait->reload sequence. Rare, but manifests itself exactly the same way as described in the #25436.