Skip to content

Update amp-fit-text AMP4EMAIL tagspec#25246

Merged
honeybadgerdontcare merged 3 commits intoampproject:masterfrom
honeybadgerdontcare:amp-email
Oct 25, 2019
Merged

Update amp-fit-text AMP4EMAIL tagspec#25246
honeybadgerdontcare merged 3 commits intoampproject:masterfrom
honeybadgerdontcare:amp-email

Conversation

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor

@honeybadgerdontcare honeybadgerdontcare commented Oct 24, 2019

Follow up to #24854

Restrict amp-fit-text AMP4EMAIL tagspec to only html_format: AMP4EMAIL.

@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Oct 24, 2019

Hey @ampproject/wg-caching, these files were changed:

  • extensions/amp-fit-text/validator-amp-fit-text.protoascii

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor Author

honeybadgerdontcare commented Oct 24, 2019

@choumx as an aside to this would it be okay to remove requires_usage: GRANDFATHERED and deprecated_allow_duplicates: true for these AMP4EMAIL specific tagspecs? This would affect amp-accordion, amp-fit-text, and amp-form. Can be done in a separate PR.

@westonruter westonruter mentioned this pull request Oct 24, 2019
Merged
5 tasks
@dreamofabear
Copy link
Copy Markdown

dreamofabear commented Oct 24, 2019

as an aside to this would it be okay to remove requires_usage: GRANDFATHERED and deprecated_allow_duplicates: true for these AMP4EMAIL specific tagspecs?

I think that should be fine. Would you mind also creating a tracking issue so we can label and communicate it appropriately?

@honeybadgerdontcare
Copy link
Copy Markdown
Contributor Author

honeybadgerdontcare commented Oct 24, 2019

@choumx by tracking issue...is that a Release tracking issue or Intent-to-deprecate or just an issue of some form? =D

@dreamofabear
Copy link
Copy Markdown

dreamofabear commented Oct 24, 2019

Heh, yea I was thinking of an "intent-to-deprecate" issue.

@honeybadgerdontcare honeybadgerdontcare merged commit 05e527c into ampproject:master Oct 25, 2019
@honeybadgerdontcare honeybadgerdontcare deleted the amp-email branch October 25, 2019 00:02
@honeybadgerdontcare honeybadgerdontcare mentioned this pull request Oct 25, 2019
Closed
westonruter referenced this pull request Oct 25, 2019
AMP4Email: Disallow "latest" extension scripts (#24854)
69efec0 
* Disallow -latest.js alias in AMP4EMAIL.

* Add feature test.

* Update validator_test.js.

* Add spec_name for amp-timeago, update # of versions test.

* Fix no_latest_extension.out.
twifkak added a commit to twifkak/amphtml that referenced this pull request Oct 30, 2019
@twifkak
cl/277373856 Revision bump for ampproject#25246
661363b
@twifkak twifkak mentioned this pull request Oct 30, 2019
Merged
twifkak added a commit that referenced this pull request Oct 30, 2019
@twifkak
Validator rollup (#25322)
2aa15fa 
* cl/276564440 Add warnings about modifying public function interfaces.

* cl/277373856 Revision bump for #25246

* cl/277373931 Revision bump for #25254
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
@honeybadgerdontcare
Update amp-fit-text AMP4EMAIL tagspec (ampproject#25246)
0c1c6ea 
* Update amp-fit-text AMP4EMAIL tagspec

* Remove AMP4EMAIL from version: latest tagspec

* update test
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Dec 27, 2019
@twifkak
Validator rollup (ampproject#25322)
6a16730 
* cl/276564440 Add warnings about modifying public function interfaces.

* cl/277373856 Revision bump for ampproject#25246

* cl/277373931 Revision bump for ampproject#25254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreamofabear dreamofabear dreamofabear approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@honeybadgerdontcare @dreamofabear @googlebot