Validator roll up#25224
Merged
honeybadgerdontcare merged 2 commits intoampproject:masterfrom Oct 23, 2019
honeybadgerdontcare:val-error-category-stub
Merged
Validator roll up#25224honeybadgerdontcare merged 2 commits intoampproject:masterfrom honeybadgerdontcare:val-error-category-stub
honeybadgerdontcare merged 2 commits intoampproject:masterfrom
honeybadgerdontcare:val-error-category-stub
Conversation
added 2 commits
October 23, 2019 12:07
Gregable
approved these changes
Oct 23, 2019
Closed
|
Was the previous behavior to always return UNKNOWN? I'm not sure the purpose of this function but it seems like it should be ERROR/WARN. |
Member
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/275942712 Fix validator issue with error'ing tags satisfying unique requirements. * cl/276319310 Restore a stub of amp.validator.categorizeError in javascript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a stub for error category, fixes #25188