🐛✅ <header> -> <head> to fix test flake#25145
Merged
jpettitt merged 1 commit intoampproject:masterfrom Oct 18, 2019
Merged
Conversation
ChrisAntaki
approved these changes
Oct 18, 2019
kristoferbaxter
approved these changes
Oct 18, 2019
Contributor
kristoferbaxter
left a comment
There was a problem hiding this comment.
Approved, but should we run these examples thru the validator to ensure they are valid?
This would have caught the specific issue here (and might discover other cases where fixtures are slightly invalid).
Contributor
Author
jeffjose
pushed a commit
to jeffjose/amphtml
that referenced
this pull request
Oct 19, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test fixture had
<header>instead of<head>this meant that the code designed to prevent extension race conditions was failing because the scripts were not found in<head>resulting in a hard to track test flake.