🐛Fix script tag validation issues with amp-experiment usage on amp-story#24909
Merged
gmajoulet merged 8 commits intoampproject:masterfrom Oct 10, 2019
Merged
Conversation
|
Hey @newmuis, these files were changed:
Hey @ampproject/wg-caching, these files were changed:
|
extensions/amp-story/1.0/test/validator-amp-story-amp-experiment.html
Outdated
Show resolved
Hide resolved
Contributor
|
@banaag for review |
gmajoulet
approved these changes
Oct 4, 2019
extensions/amp-story/1.0/test/validator-amp-story-amp-experiment.html
Outdated
Show resolved
Hide resolved
Enriqe
reviewed
Oct 7, 2019
extensions/amp-story/1.0/test/validator-amp-story-amp-experiment.out
Outdated
Show resolved
Hide resolved
636237e to
28deffb
Compare
Enriqe
approved these changes
Oct 8, 2019
Contributor
|
Friendly ping @banaag |
honeybadgerdontcare
requested changes
Oct 9, 2019
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
Please add the license to the test files.
honeybadgerdontcare
approved these changes
Oct 10, 2019
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
validation looks good
honeybadgerdontcare
added a commit
that referenced
this pull request
Oct 16, 2019
Merged
honeybadgerdontcare
added a commit
that referenced
this pull request
Oct 16, 2019
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 22, 2019
* cl/274603953 Revision bump for ampproject#24854 * cl/274639638 Revision bump for ampproject#24909
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
…ory (ampproject#24909) * Fix script tag validation issues with amp-experiment usage on amp-story * Reformat comments and fix invalid amp-experiments * Update outfile to reflect changes on comments and amp-experiments * Add newline to ends of test files * Add passing test for amp-story amp-experiment validator * Add newlines to ends of outfiles * Add license to test files * Add license addition to validator test outfiles
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/274603953 Revision bump for ampproject#24854 * cl/274639638 Revision bump for ampproject#24909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the amp-validator would flag script tags used inside amp-experiment tags would flag the validator for
[CUSTOM_JAVASCRIPT_DISALLOWED].Resolves #24748