Skip to content

Fix the regression caused by resources->owners refactoring#23868

Merged
powerivq merged 2 commits intoampproject:masterfrom
powerivq:fix-23858
Aug 9, 2019
Merged

Fix the regression caused by resources->owners refactoring#23868
powerivq merged 2 commits intoampproject:masterfrom
powerivq:fix-23858

Conversation

@powerivq
Copy link
Copy Markdown
Contributor

@powerivq powerivq commented Aug 9, 2019

This was a mishandling while doing the refactoring. This PR fixes #23858

Also needed to be cherry picked to canary. Prod is not affected.

Copy link
Copy Markdown
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amp-bundle-size amp-bundle-size bot requested a review from jridgewell August 9, 2019 19:29
@powerivq powerivq merged commit 2e775bd into ampproject:master Aug 9, 2019
@powerivq powerivq deleted the fix-23858 branch August 9, 2019 21:47
dreamofabear pushed a commit that referenced this pull request Aug 12, 2019
* Fix the regression caused by resources->owners refactoring

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Cannot read property '__AMP__RESOURCE' of undefined at Z

5 participants