amp-consent consent-ui: Show/Hide the AMP Viewer when amp-consent CMPs enterFullScreen#23491
Conversation
|
|
||
| this.resetAnimationStyles_(); | ||
|
|
||
| this.viewer_.sendMessage( |
There was a problem hiding this comment.
I think we should use the Viewport.enterLightboxMode() instead?
There was a problem hiding this comment.
So enterLightboxMode() does a lot more than I think is neccessary. see my response here to @jridgewell 😄
There was a problem hiding this comment.
I do see that it handles fixed layer and and FIE.
In our case, the FIE won't be an issue because the request can never be from a component in FIE. But I find it's doesn't hurt to include it.
Not sure about fixed layer. @jridgewell could you please help us understand if the message is enough here instead of calling Viewport.enterLightBoxMode(). Thanks.
There was a problem hiding this comment.
If it's an already fixed position element, it might not need any special fixed-layer support?
There was a problem hiding this comment.
Yeah I don't think it requires any special fixed-layer support 😄
|
|
||
| this.resetAnimationStyles_(); | ||
|
|
||
| this.viewer_.sendMessage( |
There was a problem hiding this comment.
If it's an already fixed position element, it might not need any special fixed-layer support?
|
Thank you @torch2424 for figuring this out! 🎉 |
|
Thank you @zhouyx and @jridgewell ! Merging... |
…sent CMPs enterFullScreen (ampproject#23491)" This reverts commit e705649.
relates to #22943 (Maybe closes, but still investigating the issue)
closes #22994
This hides/shows the viewer bar (similar to amp-lightbox), when the consent-ui goes into the fullscreen mode 😄
Example