Skip to content

🏗 Add Apache Ant v1.10.6 to third_party/ant#23490

Merged
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2019-07-23-ThirdPartyAnt
Jul 23, 2019
Merged

🏗 Add Apache Ant v1.10.6 to third_party/ant#23490
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2019-07-23-ThirdPartyAnt

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented Jul 23, 2019 •
edited
Loading

This PR adds a copy of Apache Ant to third_party/ant/. See #23434 (comment)

README.amp file:

URL: https://ant.apache.org/
License: Apache
License File: https://www.apache.org/licenses/LICENSE-2.0.txt

Description:
Copy of `bin/` and `lib/` directories of Apache Ant from release v1.10.6
https://www-us.apache.org/dist//ant/binaries/apache-ant-1.10.6-bin.zip

Addresses #23434 (comment)
Required for #23434
Partial fix for #22452

@rsimha rsimha requested review from erwinmombay and jridgewell July 23, 2019 21:22
@rsimha rsimha self-assigned this Jul 23, 2019
@rsimha rsimha mentioned this pull request Jul 23, 2019
Merged
@rsimha
Copy link
Copy Markdown
Contributor Author

rsimha commented Jul 23, 2019

/to @erwinmombay @jridgewell

@erwinmombay
Copy link
Copy Markdown
Member

erwinmombay commented Jul 23, 2019

approving to unblock other PR. this is the whole of ANT huh? do you happen to know how much bytes this add to the repo?

@rsimha
Copy link
Copy Markdown
Contributor Author

rsimha commented Jul 23, 2019

approving to unblock other PR. this is the whole of ANT huh?

It's not the whole of Ant. Just the lib/ and bin/ directories, which are sufficient to be able to run it.

do you happen to know how much bytes this add to the repo?

The third_party/ant/ directory is 3.1M in size.

rsimha@bobdylan (2019-07-23-ThirdPartyAnt):~/src/amphtml/third_party$ du -h ant/
76K	ant/bin
3.0M	ant/lib
3.1M	ant/

@rsimha rsimha merged commit 457027a into ampproject:master Jul 23, 2019
@rsimha rsimha deleted the 2019-07-23-ThirdPartyAnt branch July 23, 2019 22:31
rindo pushed a commit to logly/amphtml that referenced this pull request Jul 24, 2019
@rsimha
🏗 Add Apache Ant v1.10.6 to third_party/ant (ampproject#23490)
10c489e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees

@rsimha rsimha

Labels

cla: yes WG: infra

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsimha @erwinmombay @googlebot