🏗 Replace NoInline suffix check in runner.jar with the @noinline closure annotation#23363
Merged
rsimha merged 4 commits intoampproject:masterfrom Jul 17, 2019
rsimha:2019-07-16-NoInline
Merged
🏗 Replace NoInline suffix check in runner.jar with the @noinline closure annotation#23363rsimha merged 4 commits intoampproject:masterfrom rsimha:2019-07-16-NoInline
NoInline suffix check in runner.jar with the @noinline closure annotation#23363rsimha merged 4 commits intoampproject:masterfrom
rsimha:2019-07-16-NoInline
Conversation
Contributor
Author
jridgewell
approved these changes
Jul 17, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
…` closure annotation (ampproject#23363)
This was referenced Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AmpCodingConvention.javachecks function names for theNoInlinesuffix to prevent them from being inlined by closure compiler.NoInline_, which doesn't match the suffix because of the underscore@noinlineannotation that has the same result (See An annotation to either prevent or force inlining of a function google/closure-compiler#2751 and google/closure-compiler@9cc62fa)This PR removes all custom suffix code and replaces it with
@noinlineannotations.Partial fix for #17120 and #22452