Update amp-twitter validation for moments and timelines#23137
Merged
cathyxz merged 1 commit intoampproject:masterfrom Jul 2, 2019
Merged
Update amp-twitter validation for moments and timelines#23137cathyxz merged 1 commit intoampproject:masterfrom
cathyxz merged 1 commit intoampproject:masterfrom
Conversation
d0d87c2 to
8b80c22
Compare
Gregable
approved these changes
Jul 1, 2019
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Jul 9, 2019
Merged
twifkak
added a commit
that referenced
this pull request
Jul 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20340.
The attributes
themeandlink-colorare applicable to Tweets, Moments and Timelines. Since we already validate that one ofdata-momentid,data-timeline-source-type, ordata-tweetidmust be present, there is no need to additionally validate these since we pass on alldata-attributes.