Skip to content

Revert #22812#23069

Merged
lannka merged 2 commits intoampproject:masterfrom
lannka:revert-a31a1bf97
Jun 27, 2019
Merged

Revert #22812#23069
lannka merged 2 commits intoampproject:masterfrom
lannka:revert-a31a1bf97

Conversation

@lannka
Copy link
Copy Markdown
Contributor

@lannka lannka commented Jun 27, 2019

The PR caused side effect on some reporting due to the new "nextTick" behavior in navTiming macro.

/cc @jeffkaufman

@lannka lannka requested a review from zhouyx June 27, 2019 16:07
@zhouyx
Copy link
Copy Markdown
Contributor

zhouyx commented Jun 27, 2019

Revert #22812 to fix #23071 when we are trying to find the root cause.

@lannka lannka merged commit 88d05f5 into ampproject:master Jun 27, 2019
@lannka lannka deleted the revert-a31a1bf97 branch June 27, 2019 17:18
@sparhami
Copy link
Copy Markdown

When cherry-picking this onto production, I ran into a merge conflict. While easy enough to resolve, it does make me concerned that there have been changes to the files since.

How extensively has this been tested on top of the existing production build?

sparhami pushed a commit that referenced this pull request Jun 27, 2019
* Revert #22812

* Revert #22812
@lannka
Copy link
Copy Markdown
Contributor Author

lannka commented Jun 27, 2019

@sparhami I got conflict only in test files. Did you get something else?

@zhouyx
Copy link
Copy Markdown
Contributor

zhouyx commented Jun 27, 2019

@sparhami Can we cherrypick the change to canary first. And only cherrypick to prod once we've verified the fix in inabox RC.

@sparhami
Copy link
Copy Markdown

@sparhami I got conflict only in test files. Did you get something else?

I just want to make sure there aren't any other potentially conflicting changes. The lack of a merge conflict in the non-test files does not guarantee this. Since the original issue wasn't covered by a test, relying on tests seems to not be sufficient. For example, a hypothetical PR submitted after the PR that is being rolled back, that depends on it could run into issues once we rollback.

@sparhami
Copy link
Copy Markdown

@sparhami Can we cherrypick the change to canary first. And only cherrypick to prod once we've verified the fix in inabox RC.

It seems like there might be another cherry-pick request for canary. I'm currently waiting to see if that will happen to combine the two before doing a canary cherry-pick.

@zhouyx
Copy link
Copy Markdown
Contributor

zhouyx commented Jun 27, 2019

It seems like there might be another cherry-pick request for canary. I'm currently waiting to see if that will happen to combine the two before doing a canary cherry-pick.

Sounds good. FYI: While the change is in prod already, but it's not affecting ampdoc. The change is still in inabox canary, and we need the canary cherry-pick mainly for inabox RC.

@sparhami
Copy link
Copy Markdown

Looks like a test is failing when cherry picking on top of production, in single pass, local tests and sauce lab tests:

https://travis-ci.org/ampproject/amphtml/builds/551509527

DESCRIBE => amp-analytics
  DESCRIBE => basic pageview
    DESCRIBE =>  
      IT => should send request
        ✗ Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

This seems to fail every time I try it locally.

Here is the branch with the cherry pick:
https://github.com/ampproject/amphtml/tree/amp-release-2019-06-27-prod

Here is the cherry picked commit on top of prod: d0eb22b

The changes should be the same as this PR.

@lannka @zhouyx Any ideas?

sparhami pushed a commit that referenced this pull request Jun 27, 2019
* Revert #22812

* Revert #22812
@zhouyx
Copy link
Copy Markdown
Contributor

zhouyx commented Jun 27, 2019

That's weird. Let me try running it locally

@zhouyx
Copy link
Copy Markdown
Contributor

zhouyx commented Jun 28, 2019

Hello @sparhami found the reason.
It's because of invalid JSON 😢

"cid": "\${clientId(_cid)}",

unexpected comma when we resolve merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants