amp-bind: Update textarea initial value via [defaultText]#22205
Merged
dreamofabear merged 4 commits intoampproject:masterfrom May 9, 2019
Merged
amp-bind: Update textarea initial value via [defaultText]#22205dreamofabear merged 4 commits intoampproject:masterfrom
dreamofabear merged 4 commits intoampproject:masterfrom
Conversation
added 2 commits
May 8, 2019 18:02
honeybadgerdontcare
approved these changes
May 8, 2019
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
validation lgtm
Author
|
/to @cvializ |
cvializ
reviewed
May 9, 2019
Contributor
cvializ
left a comment
There was a problem hiding this comment.
Is it [defaultText] or [defaulttext]? The docs and tests seem to show defaultText but the implementation uses defaulttext.
Author
|
Good question. The implementation lowercases attribute names, so any casing will work (which is also why I wrote the tests as such). |
cvializ
reviewed
May 9, 2019
Contributor
cvializ
left a comment
There was a problem hiding this comment.
I see, thanks for explaining. LGTM!
cvializ
approved these changes
May 9, 2019
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
May 10, 2019
Merged
twifkak
added a commit
that referenced
this pull request
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21053.