🏗♻️🚮 Refactor and clean up dev dashboard code#21125
Merged
rsimha merged 5 commits intoampproject:masterfrom Feb 27, 2019
rsimha:2019-02-26-Bundle.js
Merged
🏗♻️🚮 Refactor and clean up dev dashboard code#21125rsimha merged 5 commits intoampproject:masterfrom rsimha:2019-02-26-Bundle.js
rsimha merged 5 commits intoampproject:masterfrom
rsimha:2019-02-26-Bundle.js
Conversation
Contributor
Author
alanorozco
reviewed
Feb 26, 2019
alanorozco
approved these changes
Feb 26, 2019
Member
|
Thanks for doing this, the new testing command is also easier to remember! |
estherkim
reviewed
Feb 26, 2019
torch2424
approved these changes
Feb 27, 2019
Contributor
torch2424
left a comment
There was a problem hiding this comment.
Thank you so much for doing this! 😄
alanorozco
reviewed
Feb 27, 2019
| * Run all the dev dashboard tests | ||
| */ | ||
| function runDevDashboardTests() { | ||
| const mocha = new Mocha({reporter: isTravisBuild() ? 'dot' : 'spec'}); |
Contributor
Author
|
Comments addressed. |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
babel-plugin-transform-react-jsxto@babel/plugin-transform-react-jsx(part of thebabelmonorepo)disable_dev_dashboard_cacheto an opt-in flagenable_dev_dashboard_cachegulp serveless noisy and more prettygulp test(they were unrelated) and into a newgulp dev-dashboardtaskgulp build, and runs really fast, so it belongs in theChecksjob)