Validation changes to allow parameters in animations#20992
Merged
Enriqe merged 5 commits intoampproject:masterfrom Feb 28, 2019
Merged
Validation changes to allow parameters in animations#20992Enriqe merged 5 commits intoampproject:masterfrom
Enriqe merged 5 commits intoampproject:masterfrom
Conversation
newmuis
reviewed
Feb 21, 2019
| attrs: { name: "grid-area" } | ||
| attrs: { | ||
| name: "scale-end" | ||
| value_regex: "^[0-9]*$" |
Contributor
There was a problem hiding this comment.
I think you may want to reconsider this regular expression (here and below); as it's written it will:
- Allow empty string
- Allow
0(maybe that's ok, even though it's kind of weird) - Disallow decimals
Member
There was a problem hiding this comment.
Note also that the "^" and "$" are implied. This behavior varies between different languages and implementations (javascript it's not implied), so we normalize in the validator code. You can assume that value_regex is a full match and blacklisted_value_regex is a partial match (ie: in both cases, the least likely to match or most conservative).
Contributor
Author
| attrs: { | ||
| name: "scale-end" | ||
| value_regex: "^[0-9]*$" | ||
| value_properties: { |
Contributor
There was a problem hiding this comment.
It's not possible to have multiple value settings for an AttrSpec. It's an implicit oneof. That is, it can't be both value_regex and value_properties. Please see https://github.com/ampproject/amphtml/blob/master/validator/validator.proto#L105
Contributor
Author
|
PTAL |
newmuis
approved these changes
Feb 26, 2019
11674b5 to
be8686d
Compare
gmajoulet
approved these changes
Feb 27, 2019
| | </amp-story-page> | ||
| | </amp-story> | ||
| | </body> | ||
| | </html> No newline at end of file |
Contributor
There was a problem hiding this comment.
Nit: new line (you can configure your software to add it automatically on save I think)
Contributor
Author
There was a problem hiding this comment.
Thanks. Yeah I have that enabled but I think whenever you pass the --update_tests in the validator it removes it.
/cc @Gregable as FYI
twifkak
added a commit
to twifkak/amphtml
that referenced
this pull request
Mar 7, 2019
Merged
twifkak
added a commit
that referenced
this pull request
Mar 7, 2019
* cl/235984006 Revision bump for #21124 * cl/236141405 Validating ssr class values and attributes for transformed AMP * cl/236207670 Validating SSR layout should use the SSR CalculateLayout * cl/236240396 Revision bump for #20967 * cl/236242005 Revision bump for #20992 * cl/236357124 Allow `meta name=amp-recaptcha-input` * cl/236374806 Allow `meta name=amp-list-load-more` * cl/236486003 Limit depth of recursion in CSS parsing. * cl/236922121 n/a * cl/236944297 allow i-amphtml-sizer for transformed amp-story * eslint fixes
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* validation vfx params * renaming * revise regex and update examples * don't allow half pixel values * newlines
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* cl/235984006 Revision bump for ampproject#21124 * cl/236141405 Validating ssr class values and attributes for transformed AMP * cl/236207670 Validating SSR layout should use the SSR CalculateLayout * cl/236240396 Revision bump for ampproject#20967 * cl/236242005 Revision bump for ampproject#20992 * cl/236357124 Allow `meta name=amp-recaptcha-input` * cl/236374806 Allow `meta name=amp-list-load-more` * cl/236486003 Limit depth of recursion in CSS parsing. * cl/236922121 n/a * cl/236944297 allow i-amphtml-sizer for transformed amp-story * eslint fixes
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* validation vfx params * renaming * revise regex and update examples * don't allow half pixel values * newlines
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
* cl/235984006 Revision bump for ampproject#21124 * cl/236141405 Validating ssr class values and attributes for transformed AMP * cl/236207670 Validating SSR layout should use the SSR CalculateLayout * cl/236240396 Revision bump for ampproject#20967 * cl/236242005 Revision bump for ampproject#20992 * cl/236357124 Allow `meta name=amp-recaptcha-input` * cl/236374806 Allow `meta name=amp-list-load-more` * cl/236486003 Limit depth of recursion in CSS parsing. * cl/236922121 n/a * cl/236944297 allow i-amphtml-sizer for transformed amp-story * eslint fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #20260
Allow new parameters for animations inside amp-story:
scale-start,scale-end,translate-x,translate-yscale-start/endvalues must be numbers, andtranslate-x/yvalues must be numbers and end withpx).