Revert "✨Create new extension - AMP-smartlinks"#20891
Merged
Conversation
This reverts commit 628e309.
Contributor
Author
|
cc\ @PhilWinchester |
PhilWinchester
approved these changes
Feb 15, 2019
rsimha
approved these changes
Feb 15, 2019
Contributor
rsimha
left a comment
There was a problem hiding this comment.
Sorry about the extra work.
I'm still puzzled about why gulp check-types didn't catch this. Do @erwinmombay @jridgewell or @choumx know why this might be?
jridgewell
reviewed
Feb 15, 2019
|
|
||
| // amp-smartlinks depends on amp-skimlinks/link-rewriter | ||
| 'extensions/amp-smartlinks/0.1/amp-smartlinks.js->extensions/amp-skimlinks/0.1/link-rewriter/link-rewriter-manager.js', | ||
| 'extensions/amp-smartlinks/0.1/linkmate.js->extensions/amp-skimlinks/0.1/link-rewriter/two-steps-response.js', |
Contributor
There was a problem hiding this comment.
This is disallowed, and requires explicit support in the build process.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Mar 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #20494