📖 Add docs for XML-compatible AMP bind attribute syntax#19835
Merged
dreamofabear merged 2 commits intoampproject:masterfrom Jan 16, 2019
Merged
📖 Add docs for XML-compatible AMP bind attribute syntax#19835dreamofabear merged 2 commits intoampproject:masterfrom
dreamofabear merged 2 commits intoampproject:masterfrom
Conversation
dreamofabear
approved these changes
Jan 8, 2019
dreamofabear
left a comment
There was a problem hiding this comment.
Thanks for contributing this! Made some minor edits.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
…9835) * Add docs for XML-compatible binding attribute syntax See ampproject#11115 and ampproject#15408 * Minor edits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently after the XML-compatible syntax for AMP-bind was added (#11115 and #15408), there was no corresponding docs added (see facebook/react#12568 (comment)). This adds documentation for this.