Launch amp-story-responsive-units experiment#18989
Merged
newmuis merged 1 commit intoampproject:masterfrom Oct 26, 2018
newmuis:enable-amp-story-responsive-units
Merged
Launch amp-story-responsive-units experiment#18989newmuis merged 1 commit intoampproject:masterfrom newmuis:enable-amp-story-responsive-units
newmuis merged 1 commit intoampproject:masterfrom
newmuis:enable-amp-story-responsive-units
Conversation
Enriqe
approved these changes
Oct 26, 2018
gmajoulet
approved these changes
Oct 26, 2018
warrengm
pushed a commit
to warrengm/amphtml
that referenced
this pull request
Oct 30, 2018
Contributor
|
Hi All! Apologies, but unlaunched this in #19057. We can relaunch at anytime. We just wanted to have a very clean state on the urgent release. |
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 4, 2020
prod-config.json history: d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 4, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
…d-config.json history:\n\n - d26327a - 2018-11-05T12:02:25-05:00\n Re-launch amp-story-responsive-units experiment (ampproject#19140)\n\n - d5ec88b - 2018-10-30T16:01:59-07:00\n Unlaunch amp-story-responsive-units for urgent release (ampproject#19057)\n\n - 65379df - 2018-10-26T15:27:09-04:00\n Launch amp-story-responsive-units experiment (ampproject#18989)\n
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 5, 2020
prod-config.json history: - d26327a - 2018-11-05T12:02:25-05:00 Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 Launch amp-story-responsive-units experiment (ampproject#18989)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - d26327a - 2018-11-05T12:02:25-05:00 - Re-launch,amp-story-responsive-units,experiment,(ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 - Unlaunch,amp-story-responsive-units,for,urgent,release,(ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 - Launch,amp-story-responsive-units,experiment,(ampproject#18989)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 6, 2020
Previous history on prod-config.json: - d26327a - 2018-11-05T12:02:25-05:00 - Re-launch,amp-story-responsive-units,experiment,(ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 - Unlaunch,amp-story-responsive-units,for,urgent,release,(ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 - Launch,amp-story-responsive-units,experiment,(ampproject#18989)
github-actions bot
pushed a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - d26327a - 2018-11-05T12:02:25-05:00 - Re-launch,amp-story-responsive-units,experiment,(ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 - Unlaunch,amp-story-responsive-units,for,urgent,release,(ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 - Launch,amp-story-responsive-units,experiment,(ampproject#18989)
alanorozco
added a commit
to alanorozco/amphtml
that referenced
this pull request
Dec 7, 2020
Previous history on prod-config.json: - d26327a - 2018-11-05T12:02:25-05:00 - Re-launch amp-story-responsive-units experiment (ampproject#19140) - d5ec88b - 2018-10-30T16:01:59-07:00 - Unlaunch amp-story-responsive-units for urgent release (ampproject#19057) - 65379df - 2018-10-26T15:27:09-04:00 - Launch amp-story-responsive-units experiment (ampproject#18989)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes viewport units (
vw,vh,vmin, andvmax) work within the amp-story 3-panel desktop UI.