Throttle intersection observer posts to 10 per second.#1889
Merged
cramforce merged 1 commit intoampproject:masterfrom Feb 10, 2016
Merged
Throttle intersection observer posts to 10 per second.#1889cramforce merged 1 commit intoampproject:masterfrom
cramforce merged 1 commit intoampproject:masterfrom
Conversation
Also filters out changes that happen in the same milli seconds. Deletes the `amp-iframe` intersection tests because they are super bad and I already filed ampproject#1822 to rewrite them.
| /** @private {boolean} */ | ||
| this.shouldSendIntersectionChanges_ = false; | ||
| /** @private {Array<function>} */ | ||
| this.unlisteners_ = []; |
Contributor
There was a problem hiding this comment.
No longer need to unlisten?
Member
Author
There was a problem hiding this comment.
This code was never used. If we want to kill entire ad tags, we'd need to add this again.
Contributor
|
LGTM. One question that can be answered post-merge. |
cramforce
added a commit
that referenced
this pull request
Feb 10, 2016
Throttle intersection observer posts to 10 per second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also filters out changes that happen in the same milli seconds.
Deletes the
amp-iframeintersection tests because they are super bad and I already filed #1822 to rewrite them.