Reference sourcemaps from GitHub.#1887
Conversation
|
@erwinmombay Could we pass the tag as a flag to the compile step instead? |
|
@cramforce definitely doable, is that so we can get to the version folder? |
|
Nah, we point at Github just with the tag in the URL to get sources at the right version. |
build-system/tasks/compile.js
Outdated
There was a problem hiding this comment.
so if we had the tag should be something like https://rawgit.com/ampproject/amphtml/1454976295735/src/
ex: https://rawgit.com/ampproject/amphtml/1454976295735/src/3p.js
|
|
|
@cramforce so since the future tag is going to be |
|
@erwinmombay yep! |
|
@jridgewell Not sure what you mean? We need the raw source. |
|
@cramforce LGTM pending, the tag version change to the path |
|
Never mind my comment. |
This is better than local, but ideally this would point at the right tag.
5a8af83 to
d804ad3
Compare
|
Arghh, it works with the tag, but we are missing all the build artifacts. The right solution is to embed the source file into the map as a data-uri. |
|
But, it is still pretty nice step forward, so lets roll with it. |
Reference sourcemaps from GitHub.
This is better than local, but ideally this would point at the right tag.