Validation roll-up#1879
Merged
Gregable merged 9 commits intoampproject:masterfrom Feb 9, 2016
Gregable:validation
Merged
Conversation
- Avoid using the return value of addPositionTo (which is Token, not ErrorToken) - Assert that the elements returned by querySelectorAll are HTMLElement instances.
Create new UrlSpec usable by AttrSpec for allowed protocols in href/src attributes. Validate URLs are not missing Validate URLs are valid (via goog.Uri.parse) Validate protocols are allowed for certain tags Add colon to Entities list for htmlparser. Fix lookupEntity_ in htmlparser to actually look up the entity by name. anchor's href: http, https, mailto, sms, whatsapp, viber img's src: http, https amp-audio > source's src: http, https amp-video > source's src: https audio > source's src: http, https video > source's src: https amp-img's src: data, http, https amp-anim's src: data, http, https amp-video's src: https amp-ad's src: https amp-embed's src: https amp-youtube's src: https amp-twitter's src: https amp-instagram's src: https amp-iframe's src: https amp-pixel's src: https amp-audio's src: http, https amp-list's src: https amp-install-serviceworker's src: https
sync with the published spec.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Contributor
|
@googlebot confirmed. |
1 similar comment
Contributor
|
@googlebot confirmed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handful of changes to validate various tags: carousel, install-serviceworker, wordpress rel=attachment.
Note: Significant change to start validating URLs in attribute values for tags such as
<img src=or<a href=.Affects Github #1711, Github #1847