🐛Added Mute/Unmute Controls to <amp-ima-video>#18611
Merged
torch2424 merged 3 commits intoampproject:masterfrom Oct 9, 2018
Merged
🐛Added Mute/Unmute Controls to <amp-ima-video>#18611torch2424 merged 3 commits intoampproject:masterfrom
torch2424 merged 3 commits intoampproject:masterfrom
Conversation
Contributor
Author
|
Going to look for an IMA team member to give this a review 😄 |
Contributor
|
Should we put the mute button on the left side or right side? |
Contributor
Author
|
IMA team doesn't have bandwidth, and @spacedino approved of the media button on the right side 😄 cc @zhouyx |
Contributor
|
One more request, can I see the UI in mobile? Otherwise looks awesome! Thank you for digging into the code and let's ship it! |
Contributor
Author
|
Showed Mobile UI in person to @zhouyx Thanks for the LGTM Merging 😄 |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Oct 18, 2018
* Fixed the ima video example * Finished the Mute/UnMute * Fixed all testing and liniting errors
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Fixed the ima video example * Finished the Mute/UnMute * Fixed all testing and liniting errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #18531
This adds mute/unmute controls to
<amp-ima-video>😄 Also, does some updating to the<amp-ima-video>that makes it usable on desktop, and offers more context on ima, and it's example implementation.Examples