Rollback CC upgrade (#18552)#18600
Merged
dreamofabear merged 1 commit intoampproject:masterfrom Oct 8, 2018
Merged
Conversation
erwinmombay
approved these changes
Oct 8, 2018
rsimha
approved these changes
Oct 8, 2018
kristoferbaxter
approved these changes
Oct 8, 2018
Contributor
kristoferbaxter
left a comment
There was a problem hiding this comment.
:( Let me know if I can help with fixing the issues.
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Oct 8, 2018
This reverts commit 6fd3044.
dreamofabear
pushed a commit
that referenced
this pull request
Oct 10, 2018
* Revert "Revert CC upgrade. (#18600)" This reverts commit 6fd3044. * Remove node_modules/ from js_module_root. * Fix swg.js again. * Increase bundle size cap to 82.2. * Inject react-dates bundle post-compile instead of importing in code. * Typecast react-dates imports in amp-date-picker. * Bump bundle-size. * Restore --js_module_root for 1-pass. * Remove obsolete 'erwinmHack'.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Oct 18, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Oct 18, 2018
* Revert "Revert CC upgrade. (ampproject#18600)" This reverts commit 6fd3044. * Remove node_modules/ from js_module_root. * Fix swg.js again. * Increase bundle size cap to 82.2. * Inject react-dates bundle post-compile instead of importing in code. * Typecast react-dates imports in amp-date-picker. * Bump bundle-size. * Restore --js_module_root for 1-pass. * Remove obsolete 'erwinmHack'.
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* Revert "Revert CC upgrade. (ampproject#18600)" This reverts commit 6fd3044. * Remove node_modules/ from js_module_root. * Fix swg.js again. * Increase bundle size cap to 82.2. * Inject react-dates bundle post-compile instead of importing in code. * Typecast react-dates imports in amp-date-picker. * Bump bundle-size. * Restore --js_module_root for 1-pass. * Remove obsolete 'erwinmHack'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls back #18552 to unbreak master. There are a few problems of modules not being resolved correctly, for example from
src/polyfills/promise.js:There are 12 instances of these undefined
module$foo$baraliases in v0.js. The other problematic module is:I'll roll forward again when I figure out what the issue with
node_modules/imports is.